ENH: add dd.sylvan.Function.count()
#106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the addition. I agree with the reasoning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the method Function.count() in the Sylvan interface.
Following earlier discussion, this leaves open the question of how many ways to have for performing an operation. Nonetheless, I think adding
count()is motivated here becausedd.sylvansupport a method already supported by the CUDD and autoref implementations, andcount()in this way since at least 3 years ago, so we might imagine there is code in the wild that follows the pattern.I did not expose
nvarsas a parameter for the same reason it was not included indd.sylvan.BDD.count(). The usefulness is not clear to me, so I suggest that we wait until a user asks for it.